Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always ssl between flink-containers #86

Merged
merged 25 commits into from
Aug 9, 2023
Merged

Always ssl between flink-containers #86

merged 25 commits into from
Aug 9, 2023

Conversation

mbjtrifork
Copy link
Member

No description provided.

AndersBennedsgaard
AndersBennedsgaard suggested changes Aug 7, 2023
View reviewed changes
charts/flink-job/templates/flink-deployment.yaml Show resolved Hide resolved
charts/flink-job/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/Chart.yaml Outdated Show resolved Hide resolved
AndersBennedsgaard
AndersBennedsgaard suggested changes Aug 8, 2023
View reviewed changes
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/values.yaml Outdated Show resolved Hide resolved
charts/flink-job/templates/secret.yaml Outdated Show resolved Hide resolved
charts/flink-job/templates/cert.yaml Outdated Show resolved Hide resolved
charts/flink-job/templates/cert.yaml Outdated Show resolved Hide resolved
AndersBennedsgaard
AndersBennedsgaard approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@AndersBennedsgaard AndersBennedsgaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mbjtrifork mbjtrifork merged commit f3821f9 into main Aug 9, 2023
4 checks passed
@mbjtrifork mbjtrifork deleted the feature/flink-ssl branch August 9, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersBennedsgaard AndersBennedsgaard AndersBennedsgaard approved these changes

@pegtrifork pegtrifork Awaiting requested review from pegtrifork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbjtrifork @AndersBennedsgaard